search

passbolt / charts-passbolt

Helm charts to run Passbolt on Kubernetes. No strings attached charts to run the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
40 stars 27 forks source link

feat: expose the HTTP port in the service #62

Closed Kuruyia closed 3 months ago

Kuruyia commented 8 months ago

This modifies the service to also expose the HTTP service. My use case is that, in my cluster, TLS termination is handled by the ingress controller and TLS certificates are managed by cert-manager, so that the application does not have to worry about TLS at all (I think this is a very common setup).

The service key in the values was also updated to allow modifying the port, targetPort and name keys of both the HTTP and HTTPS ports.

This is a breaking change. As this is a change I would very much like to see in upstream, please tell me if something needs to be done about backwards compatibility.

dlen commented 8 months ago

Hello!

We will be (most likely next month) doing a release 1.0 that will include the breaking changes you suggest in this PR along some other changes. Hope that you can wait a bit more!

Thanks a lot for your contributions, really appreciated!

Kuruyia commented 8 months ago

Hi!

I have no problem waiting, I can use my fork in the meantime 😄

Thanks a lot for merging my contributions!

alexiiiiiiiiiiiiiii commented 5 months ago

Any news about this ? :)

dlen commented 5 months ago

Hey, thanks for the interest, we'll probably release this, with all the other breaking changes and create a v1.0 of the chart in a couple of weeks. Thanks for your patience!

Xhelliom commented 4 months ago

Hello :) Any information of when the 1.0 of the chart will be release ? Thanks in advance and thank you for your good work 🥇

dlen commented 4 months ago

Hello @Xhelliom! Thanks for the kind words! :heart:

We are planning to work on the chart in a couple of weeks, our bandwidth is a bit limited so bear with us :)

MariiAnet commented 3 months ago

Hi!

Any news about the chart release?

dlen commented 3 months ago

Hello!

Yes, we have been working on it this last few days and next week it will be out as a release candidate for people to test as it contains few breaking changes.