search

passbolt / charts-passbolt

Helm charts to run Passbolt on Kubernetes. No strings attached charts to run the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
40 stars 27 forks source link

feat: add value for supplying an existing secret containing the JWT server keypair #67

Closed Kuruyia closed 6 months ago

Kuruyia commented 8 months ago

This is pretty much #60 for the JWT keypair.

This time, the value added is jwtExistingSecret to allow providing an existing secret containing the jwt.key and jwt.pem keys.

Also, it might be good to think about how the jwtCreateKeysForced, jwtServerPublic/jwtServerPrivate and jwtExistingSecret values interact with each other, as they are (imho) mutually exclusive and should not be used together. Maybe display a message to the user and abort the install of the chart? Same remark for gpgServerKeyPublic/gpgServerKeyPrivate vs. gpgExistingSecret.

dlen commented 6 months ago

Hello @Kuruyia sorry for the delay. Yeah we could think about a message to be added when jwtCreateKeysForced and jwtExistingSecret are used at the same time. This is what you are describing if I understood it correctly, right?

Kuruyia commented 6 months ago

Hi, no problem ! Yep I was thinking about that.

dlen commented 6 months ago

We'll add the message in a separate release but it is a good idea indeed. This PR has been merged in 0.7.1 we accidentally squashed the PR, sorry about that.

In any case we really appreciate your contributions!! Thanks again!