search

passbolt / charts-passbolt

Helm charts to run Passbolt on Kubernetes. No strings attached charts to run the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
40 stars 27 forks source link

Per architecture kubectl download #74

Closed ook closed 6 months ago

ook commented 6 months ago

…t kubectl version according cpu architecture

Fix: https://github.com/passbolt/charts-passbolt/issues/73

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

dlen commented 6 months ago

Hello! Thanks for your contribution! This is a duplicate of #44 which was closed as we thought it would be enough by changing the download URL in the values.yaml. However it looks like there is some traction about automatic detection of cpu arch. In that case I would reopen #44 unless there is something missing in that implementation

ook commented 6 months ago

Hello @dlen ! Thank you for this quick response. #44 can't work since uname -m won't map to dl.k8s.io path (they publish on pathes amd64 or arm64 while uname -m return x86_64 on mac (intel) and aarch64 on raspberry pi boards. My PR do the needed mapping.

I understand the env KUBECTL_DOWNLOAD_CMD is enough to bypass the issue, but it lacks some documentation: the README.md is not explicit enough (from my point of view) to guide the user to this value, and there's no "Troubleshooting" section where we could explain this problem. Since Passbolt advertises heavily the usage of raspberry pi, I'm pretty sure my PR could save some issues in this repository ^^

dlen commented 6 months ago

Alright sounds good to me. We'll continue with your PR.

Thanks a lot!