search

passbolt / lab-passbolt-admin-scripts

Useful passbolt administrator scripts
https://passbolt.com
3 stars 6 forks source link

Added exit code 1 for cases when script failed to create backup #3

Closed itvexesme closed 5 months ago

itvexesme commented 6 months ago

It allows handle backup.sh script execute issues when running from other scripts.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

dlen commented 6 months ago

Thanks for your contribution @itvexesme! I think it would be more convenient to add a set -e instead of an exit 1 If you are up to modify your PR I'll merge it.

itvexesme commented 5 months ago

@dlen As far as I understand set -e logic, it will omit all output by echo about the reason of the issue, that is not quite right.

dlen commented 5 months ago

Yeah you are right with the current implementation of the script adding set -e does not make sense unless you want to refactor it into trapping signals.

Thanks!