passbolt / lab-passbolt-ansible-collection

Source repository for https://galaxy.ansible.com/anatomicjc/passbolt
MIT No Attribution
9 stars 10 forks source link

Add support for unencrypted description field #11

Closed RobinR1 closed 10 months ago

RobinR1 commented 10 months ago

When the description field is not encrypted, the resource secrets will contain only a password instead of a JSON containing password and description. Fixes #9 by detecting if the decrypted resource secrets is a JSON or not and act accordingly. The description field will be extracted from the resource secrets if present, otherwise it will be retrieved from the unencrypted resource details.

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

RobinR1 commented 10 months ago

Note that I did not test this change against gnupg. I only tested using PGPy.

AnatomicJC commented 10 months ago

Many thanks for your PR @RobinR1 :+1:

I just added this additional commit to handle gnupg GPG library.

AnatomicJC commented 10 months ago

I published 0.0.12 with your fix: https://galaxy.ansible.com/ui/repo/published/anatomicjc/passbolt/