Add Naming Filter - Githubissues

passbolt / lab-passbolt-ansible-collection

Source repository for https://galaxy.ansible.com/anatomicjc/passbolt

MIT No Attribution

9 stars 10 forks source link

Add Naming Filter #2

Closed FSchwehla closed 2 years ago

CLAassistant commented 2 years ago

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

FSchwehla seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

AnatomicJC commented 2 years ago

Wow @FSchwehla , thank you for this another pull request.

Your filter is passbolt_nameing_check or passbolt_check_naming as I can see here ?

Maybe can you add a short example about how to use it, I guess it can be used like this:

      debug:
        var: lookup(passbolt, 'something') | passbolt_check_naming(the_regexp)

Cheers,

AnatomicJC commented 2 years ago

Maybe can you add a usage example in this playbook: https://github.com/passbolt/lab-passbolt-ansible-poc/blob/main/playbooks/example-playbook.yml ?

I tried to put there all cases of the ansible collection.

Thanks!

FSchwehla commented 2 years ago

Hi @AnatomicJC

I created a new Pull Request with three examples how to use the new lookup and the new filter https://github.com/passbolt/lab-passbolt-ansible-poc/pull/1 and the naming is fixed too.

In addition, I've added the function to check a single resource or all accessible resources for proper naming

I did some local tests, and so far, everything looks good, but if you have and improvements, feel free to comment.

Cheers