passbolt / passbolt_api

Passbolt Community Edition (CE) API. The JSON API for the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
4.63k stars 306 forks source link

SMTP Password with double quotes breaks mail sending #296

Closed Kukuruts closed 1 year ago

Kukuruts commented 5 years ago

SMTP Password with double quotes breaks mail sending

What you did

The mailbox we use for sending mails with Passbolt includes a double quote (") in it's password. I entered this password in the configuration wizard after installing Passbolt Pro.

What happened

The wizard's SMTP test worked, I got the test email. However, the password was saved escaped in the configuration file passbolt.php which broke the email configuration. To clarify: I entered 123"456 the configuration contained 'password' => '123\"456'

What you expected to happen

Because you use single quotes in your config files you don't need to escape double quotes. I just changed the password settings to 'password' => '123"456' and everything worked as expected.

cedricalfonsi commented 1 year ago

Hello from 2022. Enjoy 2018, it was awesome :)

Fixed with v3.8.0 and the SMTP settings now stored encrypted in the database.