passbolt / passbolt_api

Passbolt Community Edition (CE) API. The JSON API for the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
4.63k stars 306 forks source link

Saving a tag without changes deletes it #345

Closed samuel-apps closed 1 year ago

samuel-apps commented 4 years ago

Saving a tag without changes deletes it

What you did

I edit a tag, don't change anything, and press save

What happened

The tag seems to have disappeared entirely and immediately. Inspecting any passwords which previously had the tag in question, shows that they no longer have the tag in question.

What you expected to happen

I expected pretty much the same thing would happen as when i pressed cancel. From the end user's point of view anyway. But I would argue that it's a flaw in the API that it blatantly deletes a tag when you make a PUT request with a specific payload.

supergoudvis116 commented 4 years ago

Just came here to say, haha told you we shouldn't have switched ;-)

samuel-apps commented 4 years ago

It seems kind of like whenever a tag is edited, the API creates a new tag... I suppose it might be an issue if it immediately tried to create the same tag again?

cedricalfonsi commented 1 year ago

Sorry for the delay to answer. It seems to have been fixed. Feel free to reopen if the bug persists.