search

passbolt / passbolt_api

Passbolt Community Edition (CE) API. The JSON API for the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
4.73k stars 311 forks source link

UI Improvement: Import Passwords error modal is very small #476

Closed LordSimal closed 8 months ago

LordSimal commented 1 year ago

Import Passwords error modal is very small

Passbolt Version: v3.11.1 (https://github.com/passbolt/passbolt_api/commit/b80a6606512370687dbb37065a6e1fba27d22413) Platform and Target: -- Operating system: Debian 11 Bullseye -- PHP: 8.1.16 via FPM -- Web server: NGINX 1.18.0 -- Database server: MariaDB 10.11.2

What you did

With a fresh installation of passbolt I imported a CSV export of my previous password manager.

What happened

After all passwords have been processed I have been greeted with the following message/warning:

image

What you expected to happen

The error message is all fine and well but the fact, that the modal takes up like 20% of the browsers width + what you can see there is the maximum height I was able to adjust the textarea to so it was pretty bad to actually read the json error message in there.

I would appreciate a bigger error modal and/or the ability to change the modals size.

I attached the (adjusted) CSV file I imported to make it as reproducible as possbile (yes, I adjusted the password and removed all other data) PasswordExport.csv

Benj1er commented 1 year ago

Hello @LordSimal,

Thank you for reporting this problem. A ticket has been created under the reference PB-24585.

After a first reading of the CSV file, the Url field of this password is not validated because it exceeds the expected character limit of 1024 and the url of your password is 1076 characters long.

We take into account your remarks and will try to display the json error much more readable to the user.

Best regards