search

passbolt / passbolt_api

Passbolt Community Edition (CE) API. The JSON API for the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
4.74k stars 312 forks source link

Date not localized @ mail/user_setup_complete #490

Closed xerc closed 1 year ago

xerc commented 1 year ago

https://github.com/passbolt/passbolt_api/blob/ffc4fc9d117f44654d23698c499362e64fb186d5/src/Notification/Email/Redactor/AdminUserSetupCompleteEmailRedactor.php#L108

"Benutzer*in ist jetzt auf Passbolt aktiv und Sie können Passwörter mit ihr*ihm teilen.
 Benutzer*in wurde durch Sie **1 day** ago eingeladen.
cedricalfonsi commented 1 year ago

Thanks for the report @xerc.

The time ago transformation should be localized here.

https://github.com/passbolt/passbolt_api/blob/ffc4fc9d117f44654d23698c499362e64fb186d5/src/Notification/Email/Redactor/AdminUserSetupCompleteEmailRedactor.php#L160

Maybe other emails could also be improved, here the internal related task PB-25802.

xerc commented 1 year ago

may defaultLocale [APP_DEFAULT_LOCALE] is not overwritten/set by the users choice ref. https://book.cakephp.org/4/en/core-libraries/time.html#setting-the-default-locale-and-format-string

cedricalfonsi commented 1 year ago

Fixed with v4.3.0