passbolt / passbolt_api

Passbolt Community Edition (CE) API. The JSON API for the open source password manager for teams!
https://passbolt.com
GNU Affero General Public License v3.0
4.73k stars 311 forks source link

[PB-29115] Error message with mysql backup task #502

Open bugspencor opened 11 months ago

bugspencor commented 11 months ago

Error message with mysql backup task

What you did

I used both the cake backup task from https://help.passbolt.com/hosting/backup/package.html and the backup wrapper script from https://github.com/passbolt/lab-passbolt-admin-scripts to create a passbolt backup

What happened

In both cases a mysql error was written to the console:

Saving backup file: /var/lib/passbolt/backups/backup-2023-12-05--12-00-42/backup_1701774042.sql
mysqldump: [Warning] Using a password on the command line interface can be insecure.
mysqldump: Error: 'Access denied; you need (at least one of) the PROCESS privilege(s) for this operation' when trying to dump tablespaces
Success: the database was saved on file!

According to the last statement the dump succeeded and indeed the SQL dump looks correct.

This error was observed by several users and is also discussed in the forum: https://community.passbolt.com/t/backup-database-error/8646/8

What you expected to happen

In case of a successful backup I expect no error message in the output. With contradicting information ("error"/"success"), I don't know if the backup really succeeded.

See also zero error policy for backups e.g. https://nsrd.wordpress.com/2009/08/11/what-is-a-zero-error-policy/.

claytontstevenson commented 11 months ago

Hey @bugspencor I've made a ticket for this on our internal board. It'll be tracked as PB-29115

For this particular case the backup is successful from our perspective as we don't use a tablespace with the passbolt database.

LeXwDeX commented 9 months ago

I encountered the same error and then I had to add authorization to passboltdb's database account.

Note: This will only not display error messages.

GRANT PROCESS ON *. * TO 'passboltadmin'@'localhost';
FLUSH PRIVILEGES;
claytontstevenson commented 9 months ago

While that will clear the error from appearing that permission isn't required for passbolt to function properly so I would recommend against that to keep with the principle of least privilege. As mentioned the backup will still be successful despite that error message.

tomh4 commented 2 months ago

Any updates on this? :) while it is good to hear the backup works nonetheless, it is still an unwell feeling to see an error message appear when doing something as crucial as a backup...