passbolt / passbolt_browser_extension

Browser extensions (Firefox, Edge & Chrome) for Passbolt the open source password manager for teams
https://passbolt.com
GNU Affero General Public License v3.0
233 stars 72 forks source link

Can't share password, error in react-app.js #107

Closed elfif closed 3 years ago

elfif commented 4 years ago

Can't share password, error in react-app.js

Issue encountered

When i try to share a password (that i own / can share), the modal with edit and share tabs opens but in share tab i can't do anything, part of the UI is gone

My investigation

In Chrome devtools i have that issue : react-app.js:191 : Uncaught (in promise) TypeError: Invalid Appjs request. Resource share request should contain a valid resource UUID.

I debugged that code and in my case here is the issue (react-app.js, line 189) const resourceId = Object.values(data.resourceId);

resourceId seems to be an array that contains the UUID. Instead validator.isUUID requires a string as argument when I look at function definition See here : https://pub.dev/documentation/validators/latest/validators/isUUID.html

In the debugger console i executed

resourceId.join('');

while pausing the code and it worked ok that way.

On my side i just changed line 189 in react-app.js by const resourceId = data.resourceId;

And everything started to work normally again.....

I have no idea why I am the only one with that issue. I am not in charge of that install in my company but everyone using that instance seems impacted.

Do I need to submit a PR or am i looking at the wrong place ?

elfif commented 4 years ago

Ok i closed my PR because my code was dumb (i'm not a JS dev). Anyway issue is still there.

stripthis commented 4 years ago

@elfif which version of the server you are currently running?

stripthis commented 3 years ago

Closing because of inactivity