passbolt / passbolt_browser_extension

Browser extensions (Firefox, Edge & Chrome) for Passbolt the open source password manager for teams
https://passbolt.com
GNU Affero General Public License v3.0
233 stars 72 forks source link

Update react-app.js #108

Closed elfif closed 4 years ago

elfif commented 4 years ago

Issue #107 fix proposal

IMPORTANT: PLEASE READ

The best way to propose a feature is to open an issue on the community forum and discuss your ideas there before implementing them: https://community.passbolt.com/

This is only a issue tracker for issues related to the Passbolt API. For passbolt docker, browser extension, command line interface, in short any other issues please use this the other relevant repositories.

Always follow the contribution guidelines when submitting a pull request. In particular, make sure existing tests still pass, and add unit and selenium tests for all new behavior. When fixing a bug, you may want to add a test to verify the fix.

Please follow the following format:

ISSUE NAME

This pull request is a (multiple allowed):

Checklist

What you did

I added a check in passbolt.plugin.resource_share event listener. If resourceId variable we get from event data is an array containing one character per item, we transform it into a string by joining all array items. The existing code expects resourceId to be a string to be functional. My code is just a workaround. I have never contributed and know almost nothing about that project. I just did some debugging and found out where does that issue came from

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.