passbolt / passbolt_browser_extension

Browser extensions (Firefox, Edge & Chrome) for Passbolt the open source password manager for teams
https://passbolt.com
GNU Affero General Public License v3.0
231 stars 69 forks source link

Firefox plugin prevents display of XML pages #45

Closed colinfrei closed 1 year ago

colinfrei commented 6 years ago

ISSUE NAME

Passbolt extension 1.6.10, Passbolt version 2.0.1

What you did

Go to a website that outputs XML, with a Content-Type header of application/xml I expect the browser to show me the XML, something like this:

screen shot 2018-04-20 at 09 56 35

What happened

The XML displays for just a flash, then only a white page is shown. The XML is still there (I see it in view source or the network tab), it's just not being displayed.

What you expected to happen

XML should be displayed normally. When I disable the Passbolt plugin it does so again.

SergiuEnachi commented 5 years ago

XML should be displayed normally. When I disable the Passbolt plugin it does so again.

This is still actual with FF Quantum 64.0 (64-bit) running on Windows 10 (64bit) and Passbolt plugin version 2.4.6. and getting annoying to play with enabling/disabling the plugin just to have xml parsed correctly

stripthis commented 5 years ago

@SergiuEnachi I'll have a look shortly

rgpublic commented 4 years ago

Ah finally I found the culprit and this bug. I always wondered why my XML broke :-( This still happens in 2020. Any progress on this issue?

rgpublic commented 4 years ago

FWIW there seem to be numerous other extensions that also suffer from this bug: https://stackoverflow.com/questions/10649253/why-xml-file-is-not-rendered-properly-in-firefox

stripthis commented 4 years ago

@rgpublic the last time I checked I couldn't find what was causing the issue. While I can reproduce the issue, I didn't manage to identify the root cause. Initially I thought maybe passbolt was modifying the page, but that's not the case.

rgpublic commented 4 years ago

@stripthis Very mysterious. I also found this bug here, but it's supposed to be resolved:

https://bugzilla.mozilla.org/show_bug.cgi?id=1605657

Nevertheless, it happens for me. Even stranger is the fact that it doesn't happen on my machine at home, but it happens 100% reproducible on my machine here at the office. Both have the same OS, the same Firefox version, both have the Passbolt plugin installed. I'm stumped.

rgpublic commented 3 years ago

Quick tip for anyone still suffering from this: You can just add "?magic=wow" or sth. (any query string will do) to the URL to resolve this. Probably better than disabling Passbolt all the time ;-)

aTanCS commented 3 years ago

I can confirm the issue with Firefox 89.0.2 and Passbolt Extension 3.2.3. Disabling the extension fixes XML view.

garrettboone commented 3 years ago

Also from https://stackoverflow.com/questions/10649253/why-xml-file-is-not-rendered-properly-in-firefox CTRL-U opens as view-source:https://www.w3schools.com/xml/note.xml which renders fine: image This was in FF 90.0b12 (64-bit)

cedricalfonsi commented 1 year ago

Seems to have been fixed. Don't hesitate to reopen if the problem occurs again.