#66 : The browser extension doesn't build by default

[aubincleme]

The browser extension doesn't build by default

Fixes #66

This pull request is a :

• [x] bug fix
• [ ] change of existing behavior
• [ ] new feature

Checklist

• [ ] User stories are present (given, when, then format)
• [ ] Unit tests are passing
• [ ] Selenium tests are passing
• [x] Check style is not triggering new error or warning

Regarding unit tests : grunt test is passing, however, I'm unsure how to perform the rest of the extension tests. If you happen to have a guide on that that I didn't found, don't hesitate to link it to me and I'll verify the rest of the tests. :)

What you did

Just renamed two files.

• Rename gpgAuth.js to gpgauth.js
• Rename InvalidMasterPasswordError.js to invalidMasterPasswordError.js

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[cedricalfonsi]

Hello @aubincleme,

Thank you for your contribution.

This is the way to execute the tests with grunt test or with the standard npm test that is only an alias. Other integrations tests exist and can be executed directly in the browser on chrome-extension://EXTENSION_ID/test.html with an extension built in debug mode. We don't communicate on this as it's going to evolve, so don't bother with these ones.

I will review your contribution and I'll keep you posted.

[aubincleme]

Hi @cedricalfonsi ; thanks for your time :)

Apparently the tests are passing without any issues. If you need anything, don't hesitate to ping me.

[aubincleme]

Hi @cedricalfonsi ; any news on this issue ? Thanks :) !

[cedricalfonsi]

Hello @aubincleme,

It's in the current sprint, should be released within the next release.