search

passbolt / passbolt_browser_extension

Browser extensions (Firefox, Edge & Chrome) for Passbolt the open source password manager for teams
https://passbolt.com
GNU Affero General Public License v3.0
233 stars 72 forks source link

Autofill for self-hosted GitLab instance does not work #70

Closed shochdoerfer closed 5 years ago

shochdoerfer commented 5 years ago

Technically autofill does work but the wrong form gets populated. The self-hosted GitLab UI shows a login form with 2 tabs, one for LDAP logins, one for Standard logins (GitLab only users). The Standard login tab with the login form is active by default. When using autofill the form for the LDAP login get's populated, not the form that is active (visible) by default.

stripthis commented 5 years ago

@shochdoerfer thanks for the report, this is very usefull.

@cedricalfonsi I guess we should check for form fields visibility when they are severals, that should solve this one.

shochdoerfer commented 5 years ago

HTML-wise the LDAP form is located "before" the other form. So, I would assume you fill the first "password" form you can find.

stripthis commented 5 years ago

@shochdoerfer yes that's correct, that's why looking for visibility in case they are several should do the trick.

cedricalfonsi commented 5 years ago

Visibility should solve #71 too

stripthis commented 5 years ago

Fixed with v2.10.2