search

passbolt / passbolt_browser_extension

Browser extensions (Firefox, Edge & Chrome) for Passbolt the open source password manager for teams
https://passbolt.com
GNU Affero General Public License v3.0
233 stars 72 forks source link

[Fix] Manual input triggering #79

Closed OhSoooLucky closed 5 years ago

OhSoooLucky commented 5 years ago

Manual input triggering

What you did

Logging into a website that uses vue.js (R6stats.com is where I bumped into it) has the issue of the input field event not being triggered by the extension

What happened

The values will be entered, but virtual dom frameworks do not get the memo of it being there. Resulting in it returning it as 'null' or empty

What you expected to happen

It to work?

FIX: image

var event = new Event('input', {
    'bubbles': true,
    'cancelable': true
});

document.querySelector('#login_username').dispatchEvent(event);
document.querySelector('#login_password').dispatchEvent(event);

Thanks to Manno from R6Stats for checking this out for me.

stripthis commented 5 years ago

@FlyingWraptor thanks for the report, we'll test and include this fix in the next release.

stripthis commented 5 years ago

@FlyingWraptor out of curiosity, you are saying in your report that you use edge. How do you load the extension? Are there other functionalities that do not work (like clipboard or download a public key file)?

OhSoooLucky commented 5 years ago

@stripthis Great question. Honestly everything works as if it's a chrome extension. I enabled the 'Allow extensions from other stores.': image

Which allows the installation of Chrome extensions (or any chromium extension) from their respective stores. So I'm running the 2.10.1 version of Passbolt from the Chrome store: image image

But I'm positive you already knew that.

As for clipboard it works perfectly fine, remembering passwords. Auto-fill, they all work just like the Chrome extension does (haven't seen any broken stuff yet).

"Downloading a public key file" I don't really get. How am I supposed to do that?

stripthis commented 5 years ago

@FlyingWraptor thanks for the explanation.

"Downloading a public key file" I don't really get. How am I supposed to do that?

If you go to your profile and key inspector (https://yourdomain.com/app/settings/keys ) you can download your keys.

But I'm positive you already knew that.

Actually this is all news for me :)

OhSoooLucky commented 5 years ago

@stripthis Oh I thought you meant something in the extension. No that works perfectly fine as well. Good job ladds

cedricalfonsi commented 5 years ago

Fixed with v2.11.0