search

passbolt / passbolt_styleguide

Passbolt styleguide, repository of the UI elements and styles for the open source password manager for teams.
https://passbolt.github.io/passbolt_styleguide
GNU Affero General Public License v3.0
32 stars 32 forks source link

Update api_main.css #1

Closed 1Jesper1 closed 6 years ago

1Jesper1 commented 6 years ago

Fix for long urls

1Jesper1 commented 6 years ago

@kevinmuller Would you like to take a look?

stripthis commented 6 years ago

Hi Jesper,

We cannot merge this pull request. The css files are compiled from less files, you need to modify these and compile. Check the grunt tasks for this.

1Jesper1 commented 6 years ago

Thanks for the reply!

1Jesper1 commented 6 years ago

I have compiled the css from less files. Could you check if my fix does solve the problem?

stripthis commented 6 years ago

Sure will do, if that makes sense we'll include it in the next release.

stripthis commented 6 years ago

Hi @1Jesper1,

Sorry for the wait. I just had a look and I don't understand what you want to achieve with your change as I do not see any difference in terms of results in the styleguide. Do you want to wrap the urls on two lines? Currently they are truncated with an ellipsis. Like:

screen shot 2018-06-06 at 12 23 05

Can you explain / show what you are trying to do?

1Jesper1 commented 6 years ago

bug bug fix

First one is without the word-wrap, the last image is with the word-wrap added. @stripthis

stripthis commented 6 years ago

@1Jesper1 which browser / os are you using? Seems like the elipsis is not supported.

1Jesper1 commented 6 years ago

@stripthis Browser: Chrome Version 67.0.3396.62 (Official build) (64x) OS: Windows 10 64x

stripthis commented 6 years ago

Ok so the issue is not in the styleguide but in the application itself. It's missing a wrapper div to the ellispis. Closing this issue as we'll fix it with the app and not the styleguide. Thanks!

screen shot 2018-06-06 at 13 39 36 ![Uploading Screen Shot 2018-06-06 at 13.39.44.png…]()

1Jesper1 commented 6 years ago

Good to hear you found the fix! @stripthis

stripthis commented 6 years ago

Fixed with v2.1