search

passbolt / passbolt_styleguide

Passbolt styleguide, repository of the UI elements and styles for the open source password manager for teams.
https://passbolt.github.io/passbolt_styleguide
GNU Affero General Public License v3.0
32 stars 32 forks source link

Prevent more icon from wraparound #14

Closed garrettboone closed 2 years ago

garrettboone commented 3 years ago

Higher screen pixel widths do not handle current setting well. As the more icon is the right-most element, it does not need a hard width value. When it has a hard value it becomes too wide and wraps to a lower screen position. My screen resolution is reporting 1707 pixels on Passbolt container element width.

Without Fix on custom screen scaled Firefox: image

To reproduce on Chrome, scale screen smaller with Ctrl -. At 1366 screen width it's fine, but at 90% which result in 1517 pixel width, it wraps around.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

garrettboone commented 3 years ago

Not sure if you can reproduce this, but it's always been like this for me, even on attached displays.

cedricalfonsi commented 2 years ago

Hello @garrettboone

Can you confirm the issue still persists with the v3.6.0 (Published on FF, in review for Chrome & Edge)? The application was redesigned and I cannot reproduced the issue.

garrettboone commented 2 years ago

@cedricalfonsi I just checked on a FF 101 beta and it displayed properly right away with whatever settings I already had. I have attempted to re-create the problem with re-scaling the window but it does not occur. 👍 image

cedricalfonsi commented 2 years ago

Thanks for the confirmation. I'm closing the PR then.