search

passbolt / passbolt_styleguide

Passbolt styleguide, repository of the UI elements and styles for the open source password manager for teams.
https://passbolt.github.io/passbolt_styleguide
GNU Affero General Public License v3.0
32 stars 32 forks source link

Show absolute dates as dates' tooltips #24

Closed matiasgarciaisaia closed 2 years ago

matiasgarciaisaia commented 2 years ago

Whenever we show creation or modification dates in a relative format, add a tooltip with the absolute date to provide the full, exact information.

See this forum thread for context. This is the easiest possible implementation, since I was not able to see the results.

⚠️ I was not able to try the changes (there doesn't seem to be a demo page for this, and it's a bit out of my league to try and create one for now). And I do not know how to build a development version of the plugin or similar. But the code seems kind of OK.

I've also tried respecting the coding style of each of the components I was modifying.

The tests run, but I did not add any test to one of the screens since there were none to begin with (again, probably out of my league to go there).

Please do let me know if there's anything I've missed, or if there's a kind-of-easy way to test this - I may try going for the copy to clipboard version if I was able to test the thing.

I hope you know "Thanks for making Passbolt" is written as a subtext of every byte spilled here, but just in case - thanks for making Passbolt!

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

cedricalfonsi commented 2 years ago

Hello @matiasgarciaisaia,

Thank you for your contribution, it makes sense.

Your PR will be merged with the next release. Ticket reference: PB-18495

Gamabunta57 commented 2 years ago

Hello @matiasgarciaisaia :wave: !

I wanted to notify you that your code has been merged into the project. If you want to take a look at it, it's there https://github.com/passbolt/passbolt_styleguide/commit/cc96911677393b42388121bd5270ad898828eda2.

Thanks a lot for your contribution!

For some reasons I don't know, Github doesn't consider your PR as merged so I'm closing it manually.

Cheers!