Fixed an issue when compiling header file for WatchOS framework target

passepartoutvpn / openssl-apple

A script for compiling OpenSSL for Apple Devices.

Apache License 2.0

143 stars 68 forks source link

Fixed an issue when compiling header file for WatchOS framework target #10

Closed ezathashim closed 4 years ago

keeshux commented 5 years ago

@ezathashim it's the third PR for the same issue. Please take your time and be more accurate, I can't test this thoroughly now. Thanks for your contributions!

ezathashim commented 5 years ago

Yes, sorry. The problem was only found when I linked the framework into another project. There were no actual compiling issues in the openssl-apple project, so it was not immediately obvious.

Sent from my iPhone X and diggin' it!

On Jun 20, 2019, at 6:38 PM, Davide De Rosa notifications@github.com wrote:

@ezathashim it's the third PR for the same issue. Please take your time and be more accurate, I can't test this thoroughly now. Thanks for your contributions!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

keeshux commented 4 years ago

@ezathashim I'm getting this consistently when including a WatchSimulator target:

$ ./create-openssl-framework.sh dynamic
Assembling .dylib for WatchOS 6.0 (arm64_32)
Assembling .dylib for WatchOS 6.0 (armv7k)
Assembling .dylib for WatchSimulator 6.0 (i386)
ld: building for iOS, but linking in object file (obj/a_bitstr.o) built for watchOS Simulator, file 'obj/a_bitstr.o' for architecture i386

keeshux commented 4 years ago

Found the issue. Check against WatchSimulator, not WatchOSSimulator.

Anyway, my fault for not testing all these PRs (this is broken as well). I'm gonna force push your squashed submissions to master because the history has become overly confusing.