search

passepartoutvpn / openssl-apple

A script for compiling OpenSSL for Apple Devices.
Apache License 2.0
143 stars 68 forks source link

Fix dynamic bitcode #2

Closed nicph closed 6 years ago

nicph commented 6 years ago

These changes embed the bitcode in the resulting framework, and also checks the presence of the __LLVM section.

I wasn't able to re-open the PR #1.

keeshux commented 6 years ago

You could have pushed to the same branch and the PR would have included the new commit automatically. Thanks again!

keeshux commented 6 years ago

@nicph sorry if I reset the branch abruptly, but the script still has a few issues. I'll keep you posted.

nicph commented 6 years ago

My bad, i didn't test the 'static' generation since i added pipefail. The issue is due to grep -q that stops reading and closes stdin on the first match, and objdump doesn't seem to support it. I fixed this in my fork (keeping pipefail), i can open a PR if you're interested.

keeshux commented 6 years ago

@nicph good point, fixed in master already. I think we can close this PR conversation. Thanks for your support!