Fixed: Archiving not working, when Bitcode and App Thinning is enabled

passepartoutvpn / openssl-apple

A script for compiling OpenSSL for Apple Devices.

Apache License 2.0

143 stars 68 forks source link

Fixed: Archiving not working, when Bitcode and App Thinning is enabled #3

Closed hholtmann closed 5 years ago

hholtmann commented 6 years ago

This change fixes archiving not working in Xcode, when Bitcode and App thinning is enabled. Without this change Xcode still assumes openssl.dylib as installname, when doing the recompile from bitcode.

keeshux commented 6 years ago

@hholtmann how do you use the library in the project so that I can confirm the fix? Do you add the .framework package? Also, statically or dynamically built?

hholtmann commented 6 years ago

I use the dynamically build framework package in a project. To reproduce do an Archive in Xcode and then Export an Adhoc build. Select "App Thinning" for one device (e.g. iPhone 6s) in order to let Xcode recompile from Bitcode.

keeshux commented 6 years ago

@hholtmann care to double check my latest change?