search

passingthru67 / workspaces-to-dock

A gnome shell extension that transforms the workspaces into an intellihide dock
https://extensions.gnome.org/extension/427/workspaces-to-dock/
GNU General Public License v3.0
262 stars 54 forks source link

Gnome-shell crash when going to standby on Fedora 29 #158

Open evoerman opened 5 years ago

evoerman commented 5 years ago

Linux Distribution version

Fedora 29

Gnome Shell version

3.30.2

Xorg or Wayland (or both)

Xorg

Extension version or branch

Latest extensions.gnome.org version

Description of the problem

Whenever the extension is enabled and going to standby gnome-shell crashes. I've tried enabling all options of the extension one for one and trying standby, but it looks a generic issue with the extension being enabled.

Steps to reproduce the problem

Enable extension Put laptop to standby Wake laptop Gnome-shell crashes Crash also often prevents lock-screen from being shown (laptop wakes from sleep directly showing desktop with a crash notification)

sboehler commented 5 years ago

Same observation on NixOS. The bug seems to affect only Gnome on Wayland. With Gnome on Xorg, everyting works fine.

Stacktrace / journal: log.txt

AnaniTH commented 5 years ago

Got the same problem on Ubuntu with Wayland

F-i-f commented 5 years ago

Same problem here on Fedora 29, here's a stack trace:

gnome-shell[2931]: JS ERROR: InternalError: too much recursion
                                        _init/GObject.Object.prototype.disconnect@resource:///org/gnome/gjs/modules/overrides/GObject.js:468:16
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:205:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
                                        destroy@resource:///org/gnome/shell/ui/workspaceThumbnail.js:145:9
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshWindowClones@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:209:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        refreshThumbnails@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:891:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _removeWindowClone@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:409:13
                                        wrapper@resource:///org/gnome/gjs/modules/_legacy.js:82:22
                                        _addWindowClone/<@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/myWorkspaceThumbnail.js:362:26
passingthru67 commented 5 years ago

Thanks for the feedback everyone. I'll get this fixed as soon as I can. In fact, I've had to live without WtD on my Fedora laptop because of this bug. I just haven't had time to look into it.

passingthru67 commented 5 years ago

I wasn't able to duplicate the issue on my laptop, but I merged @demokritos fix for those with this issue. NOTE: Master branch will be updated to Gnome 3.32 so the fix will be in the Gnome 3.30 branch until more testing is done with 3.32.

ehrenfeu commented 5 years ago

The issue seems to be fixed for me on Ubuntu 19.04 with Gnome 3.32 and WtD Version 50 for Gnome 3.32. :heart: