search

passingthru67 / workspaces-to-dock

A gnome shell extension that transforms the workspaces into an intellihide dock
https://extensions.gnome.org/extension/427/workspaces-to-dock/
GNU General Public License v3.0
262 stars 54 forks source link

No longer works on 3.36 #189

Open docquantum opened 4 years ago

docquantum commented 4 years ago

Linux Distribution version

Arch Linux 5.5.8-1-clear

Gnome Shell version

GNOME Shell 3.36.0

Xorg or Wayland (or both)

Wayland

Extension version or branch

Current master

Description of the problem

No longer loads nor works on 3.36

Steps to reproduce the problem

Try to load the extension

ysolis commented 4 years ago

which error messages appears ? can you check your journalctl logs ?

passingthru67 commented 4 years ago

@docquantum Working on it. I should have a Gnome 3.36 compatible version ready for testing soon.

passingthru67 commented 4 years ago

@docquantum Gnome 3.36 Development branch uploaded at https://github.com/passingthru67/workspaces-to-dock/tree/gnome-3.36-dev. Please download and install manually. If there are no major issues, I'll merge into master and publish to the extensions.gnome.org site.

ysolis commented 4 years ago

@passingthru67 works for me :)

vivaeltopo commented 4 years ago

can confirm, works.

OrderlyUnicode commented 4 years ago

I was having problems loading it, but I think I installed it wrong.

Edit: I fixed it. The command from the readme.md file didn't work, because the folder I needed was nested within the extracted folder. Once I moved everything where it needed to go, it worked.

dpriedel commented 4 years ago

work for me too

thanks !!!

iJackUA commented 4 years ago

Works on Gnome 3.36, please merge it

xakraz commented 4 years ago

Works for me too for Gnome 3.36 on Manjaro !

:pray: Thanks for your work ! This extension is a must on Gnome and should be part of the built-in ones !

Keep-up the good work ! Thanks again !

:clap: :clap: :clap: :clap: :clap:

mwildam commented 4 years ago

Yes, indeed, if this extension does not work would be a showstopper for any migration! Could not find a way to donate.

Best regards, Martin.

On Thu, Mar 26, 2020 at 3:31 PM Xavier Krantz notifications@github.com wrote:

Works for me too for Gnome 3.36 on Manjaro !

🙏 Thanks for your work ! This extension is a must on Gnome and should be part of the built-in ones !

Keep-up the good work ! Thanks again !

👏 👏 👏 👏 👏

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/passingthru67/workspaces-to-dock/issues/189#issuecomment-604464223, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALU744SIVTOPMFZJQPWGJ3LRJNRNNANCNFSM4LECGWDA .

vivaeltopo commented 4 years ago

@passingthru67 deprecated warning upon shell restart:

Mar 28 11:53:24 deepthought gnome-shell[11976]: Usage of object.actor is deprecated for WorkspacesToDock_ShortcutButton get@resource:///org/gnome/shell/ui/environment.js:285:29 _createIcon@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/shortcutsPanel.js:262:13 _createIconTexture@resource:///org/gnome/shell/ui/iconGrid.js:104:26 setIconSize@resource:///org/gnome/shell/ui/iconGrid.js:97:14 _init@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/shortcutsPanel.js:153:19 _populate@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/shortcutsPanel.js:1292:38 WorkspacesToDock_ShortcutsPanel@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/shortcutsPanel.js:951:14 WorkspacesToDock_DockedWorkspaces@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/dockedWorkspaces.js:298:32 enable@/usr/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/extension.js:97:12 _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:160:32 loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:311:26 _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:536:18 collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17 _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:515:19 _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:545:18 _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:576:18 init@resource:///org/gnome/shell/ui/extensionSystem.js:54:14 _initializeUI@resource:///org/gnome/shell/ui/main.js:249:22 start@resource:///org/gnome/shell/ui/main.js:138:5 @<main>:1:47

docquantum commented 4 years ago

I get the same error

Usage of object.actor is deprecated for WorkspacesToDock_ShortcutButton
get@resource:///org/gnome/shell/ui/environment.js:285:29
_createIcon@/home/dshchur/.local/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/shortcutsPanel.js:262:13
_createIconTexture@resource:///org/gnome/shell/ui/iconGrid.js:104:26
setIconSize@resource:///org/gnome/shell/ui/iconGrid.js:97:14
_init@/home/dshchur/.local/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/shortcutsPanel.js:153:19
_populate@/home/dshchur/.local/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/shortcutsPanel.js:1292:38
WorkspacesToDock_ShortcutsPanel@/home/dshchur/.local/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/shortcutsPanel.js:951:14
WorkspacesToDock_DockedWorkspaces@/home/dshchur/.local/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/dockedWorkspaces.js:298:32
enable@/home/dshchur/.local/share/gnome-shell/extensions/workspaces-to-dock@passingthru67.gmail.com/extension.js:97:12
_callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:160:32
_onEnabledExtensionsChanged/<@resource:///org/gnome/shell/ui/extensionSystem.js:446:18
_onEnabledExtensionsChanged@resource:///org/gnome/shell/ui/extensionSystem.js:445:11
_init/createCheckedMethod/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:529:46
enableExtension@resource:///org/gnome/shell/ui/extensionSystem.js:187:29
EnableExtension@resource:///org/gnome/shell/ui/shellDBus.js:307:38
_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:327:38
_wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:404:34

Thanks for the work passingthru, it seems to work now on the new branch.

smcv commented 4 years ago

(For context: I don't use this extension myself, but I'm going through GNOME Shell extensions that are packaged in Debian and making sure there are issues open to get them adapted to an upstream change.)

One thing that isn't going to work in the gnome-3.36-dev branch: in a couple of places, this extension uses

Util.spawn(["gnome-shell-extension-prefs", Me.metadata.uuid]);

which will not work since GNOME Shell 3.36.1 (the way extension preferences work has been redone to accommodate the g-s-extension-prefs app being installed via Flatpak or similar).

As far as I can tell from GNOME Shell's upstream commit history, the preferred way to launch extension preferences in sufficiently recent versions is to call imports.misc.extensionUtils.openPrefs(), which was added by gnome-shell!1163. The version in Ubuntu 20.04 doesn't have that function available yet, but hopefully will soon; Debian experimental already has it.

To support older GNOME versions, fall back to the spawn call if imports.misc.extensionUtils doesn't have an openPrefs method.

Sample code: Tudmotu/gnome-shell-extension-clipboard-indicator#203