search

passionweb-manuel-schnabel / ai-seo-helper

Generates SEO metadata based on content using AI. Currently several metadata for pages and articles of EXT:news can be generated using an additional button next to the corresponding input fields.
9 stars 5 forks source link

Improve checking for current versioning. #14

Closed SZChimp closed 1 month ago

SZChimp commented 2 months ago

This PR will make use of proper instantiation of Typo3Version class and also use a better method to match for the TYPO3 version.

passionweb-manuel-schnabel commented 2 months ago

Hi @SZChimp ,

thanks for your PR.

Due to the fact that use statements can be used in ext_localconf.php and ext_tables.php since version 11.4 and I still support version 10.4 I can't merge your PR.

But I agree with your second suggestion to replace the instantiation of Typo3Version with the GeneralUtility approach.

If you can adjust this, I will review it again.

Greetings Manu

SZChimp commented 2 months ago

Hi Manu,

I adjusted the PR and removed the use keyword.