passkeydeveloper / passkeys.dev

source for the passkeys.dev developer site
https://passkeys.dev
Other
142 stars 31 forks source link

Device Support Matrix updates #376

Closed timcappalli closed 1 month ago

timcappalli commented 1 month ago

Changes:

Resolves #374 #373 #372 #367

cloudflare-pages[bot] commented 1 month ago

Deploying passkeys-dev with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5118537
Status: ✅  Deploy successful!
Preview URL: https://9f9ce4d2.passkeys-dev.pages.dev
Branch Preview URL: https://tc-dsm-cleanup.passkeys-dev.pages.dev

View logs

timcappalli commented 1 month ago

@g-davidson @pascoej can you please verify the new WebView text:

timcappalli commented 1 month ago

@leecam @agektmr @maudnals can you please verify the new WebView text:

g-davidson commented 1 month ago

These look great! One minor comment: on macOS, ASWebAuthenticationSession actually goes out to your default web browser (assuming it adopted the ASWebAuthenticationSession web browser API, which every major browser has), which may or may not be Safari. We do that because we assume your default browser is most likely to have your credential manager, as well as your cookies if applicable.

timcappalli commented 1 month ago

ASWebAuthenticationSession actually goes out to your default web browser

Addressed in 1f03d2a

Thanks @g-davidson!