passport-next / passport

Simple, unobtrusive authentication for Node.js.
MIT License
36 stars 5 forks source link

Fix premature redirect when used with express-session #1

Closed zypA13510 closed 6 years ago

zypA13510 commented 6 years ago

jaredhanson/passport#680

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 10


Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/middleware/authenticate.js 6 8 75.0%
<!-- Total: 6 8 75.0% -->
Totals Coverage Status
Change from base Build 9: -0.6%
Covered Lines: 353
Relevant Lines: 359

💛 - Coveralls
rwky commented 6 years ago

Note to @passport-next/developers add tests.

rwky commented 6 years ago

@guyellis just wondering if you have time to look at this? If not I'll sort it.

guyellis commented 6 years ago

@rwky probably not this week. I'll see how my time availability pans out later.