Exposed the method to customize the SessionManager object

passport-next / passport

Simple, unobtrusive authentication for Node.js.

MIT License

36 stars 5 forks source link

Exposed the method to customize the SessionManager object #14

Closed adamhathcock closed 6 years ago

adamhathcock commented 6 years ago

Exposed the method to customize the SessionManager object

Testing the waters about contributing. The project I'm about to embark on might need a few more updated passport components with a few extra features spread out.

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 36

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 96.355%

Files with Coverage Reduction	New Missed Lines	%
lib/authenticator.js	2	98.9%
<!--	Total:	2		-->

Totals
Change from base Build 35:	-0.3%
Covered Lines:	369
Relevant Lines:	375

💛 - Coveralls

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 37

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.02%) to 96.672%

Totals
Change from base Build 35:	0.02%
Covered Lines:	371
Relevant Lines:	375

💛 - Coveralls

rwky commented 6 years ago

Can you add a test for this, since it's only a small change a simple test will do.

adamhathcock commented 6 years ago

Fixed 👍

rwky commented 6 years ago

Wonderful :+1: thanks for the contribution much appreciated :)

rwky commented 5 years ago

This is now published in 2.1.0