search

passport-next / passport

Simple, unobtrusive authentication for Node.js.
MIT License
36 stars 5 forks source link

Passport-next typings #5

Open guyellis opened 6 years ago

guyellis commented 6 years ago

Question: @rwky - are you thinking of doing any Typescript typings for the passport-next modules? The existing typings for passport should be fine for passport-next for now. If the signatures and/or types change and/or evolve over time they'll become inaccurate.

The 3.0.0 version of passport-next/passport-facebook makes graphApiVersion mandatory. This is an example of how the typings for passport-next will start to drift from the current typings.

Passport typing example: https://www.npmjs.com/package/@types/passport

rwky commented 6 years ago

I've had a quick look over this and it's probably a good idea. I'm not particularly familiar with TypeScript so I won't be looking at it straight away, but we can mark this one as something to do in the future.

thib3113 commented 4 years ago

About this, I think the faster way, is to rewrite all in typescript, and set the option to auto-generate the typings .

Typescript, is mostly javascript compatible, so, in lot of cases, renaming a file from .js to .ts can be enough (for the first step only) ( with typescript configuration )

Else, I can be interessed by this project, and I can help.