Add Ability to Specify Withdrawal Amount in Passport Verifier Contract

erichfi commented 1 year ago

User Story:

As a team member managing withdrawals from the Passport Verifier Contract, I want to have the ability to specify the amount to withdraw, So that I can have more control over funds management and avoid withdrawing everything at once.

Acceptance Criteria

GIVEN the existing Passport Verifier Contract on the blockchain, WHEN a withdrawal function is triggered, THEN allow for input of a specific withdrawal amount.

Product & Design Links:

Tech Details:

Current smart contract is upgradable
Deploy to relevant testnet(s) for thorough testing before production deployment

Open Questions:

What are the security implications?
Are there any dependencies or blockers for implementing this?

Notes/Assumptions:

Assumes the current smart contract is indeed upgradable
Assumes that adding this feature will not disrupt other functionalities of the contract

aminah-io commented 1 year ago

never mind

aminah-io commented 1 year ago

Upgraded contract deployed to BaseGoerli and ready for review

aminah-io commented 1 year ago

The updated withdraw function: https://goerli.basescan.org/address/0x5bC95C6e11520D25BE8c7bDf7AAc3E2eEAbD8564#writeProxyContract#F9

passportxyz / passport