passportxyz / passport

Passport allows users to prove their identity through a secure, decentralized UI
Other
1k stars 462 forks source link

Forked, Upgradeable, and Pausable ID Staking Contract with Defined Ownership for Testnet Deployment #1839

Open erichfi opened 1 year ago

erichfi commented 1 year ago

User Story:

As a developer on the Gitcoin team, I want a fork of the existing ID staking contract to be upgradeable and pausable, with defined ownership, So that I can ensure continuity with current functionality, manage iterations, and maintain the ability to respond quickly in emergencies during the testing phase.

Acceptance Criteria

GIVEN I am configuring the ID staking contract on a testnet, WHEN I deploy the forked smart contract, THEN it should retain the existing contract's functionalities, be upgradeable for future updates without the need for a new deployment, AND it should be pausable, providing the capability to halt operations promptly in case of an emergency, AND it should have defined ownership that facilitates effective management and control, whether through a hot wallet or a multisig setup.

Product & Design Links:

N/A

Tech Details:

Open Questions:

Notes/Assumptions:

nutrina commented 1 year ago

I would also add that the SC should be pauseable.

erichfi commented 11 months ago

Also covering https://github.com/gitcoinco/passport/issues/1837 and #1838 with this issue

tim-schultz commented 10 months ago

I created a new repo for the staking contracts here https://github.com/gitcoinco/id-staking-v2

Openzeppelin released breaking changes to their Upgrades contracts and the linked pr begins implementing those new contracts

lucianHymer commented 9 months ago

Waiting on review