search

passportxyz / passport

Passport allows users to prove their identity through a secure, decentralized UI
Other
943 stars 451 forks source link

[BUG] User unable to claim Github contribution stamp #2135

Open jesuloluwao opened 7 months ago

jesuloluwao commented 7 months ago

This user not able to verify Github contribution stamp when they have contributions dating back from 2019
profile: https://github.com/Albertbm4
wallet: 0xXXXXF16A1

Link: Conversation with treblacoins@hotmail.com

Customer: treblacoins@hotmail.com Customer ID: 16d5e295-a830-4e04-8579-e7058a5baa6a

Intercom Operator will send a note to this conversation when this issue is closed.

Albertbm4 commented 7 months ago

Hello,

I have just discovered that the Passport is an open-source project, so I have done a quick peek myself.

I see that in githubClients.ts there is a hardcoded "3" in the interactions parameter, which delimits the contribution year range for 3 years from the current year. Then, it is only considering contributions from 2021 onwards.

I obviously do not know how this number is decided (perhaps to avoid more requests to the API), but I do think that older contributions help ensuring the account as a unique human.

Cheers.

erichfi commented 7 months ago

Thank you so much for the insight @Albertbm4 -- we'll think about this parameter and keep you in the loop.