search

passportxyz / passport

Passport allows users to prove their identity through a secure, decentralized UI
Other
990 stars 460 forks source link

Fix haotic diff for environment variable settings in pulumi scripts #2890

Open nutrina opened 1 month ago

nutrina commented 1 month ago

Often times when running pulumi up or pulumi diff the changes shown for the environment variables is haotic, despite the fact that the values are properly sorted in the pulumi scripts.

User Story:

As a developer, when I provision the infra I want the secrets and environment variable changes to be properly detected (and correctly ordered) in the pulumi diff So that the diff is easier to understand, and also avoid upgrades that are not otherwise required (pulumi might detect changes because of wrong ordering)

Acceptance Criteria

GIVEN I run pulumi up on any infra WHEN diff is shown THEN the changes to the environment variables is based on an diff on ordered arrays

Product & Design Links:

n. a.

Tech Details:

Open Questions:

Notes/Assumptions:

nutrina commented 3 weeks ago

This is not an issue any more. The cause for this was:

  1. if some env vars where empty in 1Password. This was messing up the diff
  2. when some items where duplicate
nutrina commented 3 weeks ago

We should double check for empty / duplicate values to make sure we don't encounter this problem during releases.

Repos to check: