search

passportxyz / passport

Passport allows users to prove their identity through a secure, decentralized UI
Other
993 stars 461 forks source link

Missing Descriptions in Stamps Sidebars #2913

Open erichfi opened 2 months ago

erichfi commented 2 months ago

Overview Multiple Stamps, such as Idena, Gitcoin, Staking, ENS, and Lens, have missing details like Credential Descriptions and Stamp Descriptions in the sidebars. This issue is likely due to an accidental code bug rather than hardcoded removal of these descriptions.

Steps To Reproduce

  1. Go to the Stamps section in the Passport app.
  2. Click on any of the affected Stamps: Idena, Gitcoin, Staking, ENS, or Lens.
  3. Observe the sidebar content.
  4. See error: Missing descriptions.

Observed behavior The sidebars for the affected Stamps (Idena, Gitcoin, Staking, ENS, Lens) do not display the Credential Descriptions and Stamp Descriptions.

Expected behavior The sidebars for the affected Stamps should display the Credential Descriptions and Stamp Descriptions as they were previously implemented.

Screenshots N/A

Additional context N/A

lucianHymer commented 2 months ago

Hey @erichfi I think these actually just have never had thorough descriptions.

Each credential can have both a title and optionally a description (ex. the Community staking credentials).

Some of the stamps just have never had a description. Originally we didn't have descriptions. With the new UI designs, the lack of a description is more noticeable.

Do you want me to make the description required and make up some descriptions?