search

passsy / CompositeAndroid

Composition over inheritance for Android components like Activity or Fragment
Apache License 2.0
515 stars 25 forks source link

Mosby #29

Open BraunreutherA opened 7 years ago

BraunreutherA commented 7 years ago

Hi,

in the documentation you wrote about integrating the mosby library as a plugin. Have you done so already? I started doing it but having some trouble to get it done. Furthermore I'd like to start a repo with common plugins - If you're interested, I would contribute them directly here.

Best Alex

passsy commented 7 years ago

I don't have an implementation of a mosby plugin because I'm using ThirtyInch for MVP. You can check the plugin implementation to get an idea. What are the troubles you are dealing with?

In my opinion, plugins for individual libraries should live in the repo of the library and not in the CompositeAndroid repo. As long as it's not part of the main project a separate repo is fine. Instead of a collection, create a separate repo for each plugin. It'll be easier to maintain.

If you wrote plugins I'd love to link them here in the README and build a collection.

BraunreutherA commented 7 years ago

Thanks for your suggestions - iI think your implementaton leads me into the right direction. The problem I had was getting the presenter into the Plugin cause it gets created in the activity/fragment via dagger as injection. I could create a interfacte like the presenter provider and let the activity implement it.