search

passwordless-id / webauthn

Webauthn / passkeys helper library to make your life easier. Client side, server side and demo included.
https://webauthn.passwordless.id
MIT License
436 stars 51 forks source link

feat: support browser extensions #46

Closed raynirola closed 5 months ago

raynirola commented 5 months ago

This PR adds support for browser extensions. No breaking change, optional mode parameter set to browser by default. Fixes #45

dagnelies commented 5 months ago

That looks quite odd and seem to differ from what the specs says. But it would not be the first time that reality differs from the specs. 🙄

That said, I'd rather allow people to customize/override rp.id/name instead. It's more intuitive, simpler to understand and would also solve the subdomains and iframes use cases.

dagnelies commented 5 months ago

Solved here instead: https://github.com/passwordless-id/webauthn/commit/1c005db8822a970dc671985a3f7f4f6062b7b8af

You can now override rp:{id:..., name:...} in the registration options