passwordmaker / android-passwordmaker

Password Maker written for the Android OS
http://passwordmaker.org
GNU General Public License v3.0
15 stars 8 forks source link

Release 2.0.0 #16

Closed tasermonkey closed 10 years ago

tasermonkey commented 10 years ago

Tagging: @passwordmaker/admin-users @Pledkae

I think I am finally able to release this version. I would appreciate a quick trail run again, before I do this.

https://github.com/passwordmaker/android-passwordmaker/releases/tag/v2.0.1

I fixed the issue with the inability to delete profiles, by using the Contextual Action Bar patter(suggested by google's developer's guide). Where you long click it will then bring up 2 actions in the action bar, 1 for deleting, one for manually setting the action.

UI issue though is: icons for all of these actions. Since a bit of these actions don't have really an icon that android provides I don't really have icons to use, because well, I suck at making icons. I tried to fit the best icon for each action that I could though.

Cool feature I decided to implement after reading the chrome issues... It should now import the 'classic' profiles that the android version used. Favorites associated with each profile is now added as a favorite (which is now not profile specific), and then added as a "pattern" to the profile (I stole this idea ish from the chrome plugin). This way it will still be auto selected. I was trying to get it so that the application you don't need/want to manually select a profile, but you just select your input text, and the application knows what profile you want from the context. But obviously there are reasons to manually select one, like maybe multiple accounts on the same site, to which I allow manually selecting. Maybe in a later release I can figure out a way to auto select them still. I don't actually delete the old classic profiles, so if I have to downgrade the application, the older version should still be able to load its profiles.

I want to get this out now, cause I want to work on an android keyboard to do the password entry. Thats the one feature I really miss from my trail of LastPass.

Pledkae commented 10 years ago

Hi,

I've run a quick test of v2.0.1 and have no issues to report. Manual selection / deletion of profiles works fine, a handy feature really.

What I miss from Firefox version, though, is the Notes field from General tab. I've realized that I've added some notes to several accounts and they're missing here. Should I ditch notes or is there a possibility of implementing them in Android version?

Another thing I'd like to see (if possible, of course) is the username for the (auto)selected account on the main screen, below/above the generated password. Just an idea...

Cheers!

tasermonkey commented 10 years ago

Notes field should be very easy to add. I just have to see what field is written to the RDF for it. Add it to the object, then add a EditText to the gui for it.

I have all of the information at the time it auto-selects. So yeah, it makes sense to display that. Its probably a good step to have anyways. My goal is to get it to be as convenient to use as say last pass. I don't see it can't be, as instead of in last pass you giving a password in it to decrypt the other passwords, you just use the password to generate the passwords based on the account. Then it also can autofill in the username's in most apps on android.

tasermonkey commented 10 years ago

I am going to release this now, and I will make those changes in the very near future. Both suggestions I like, and both are easy to do as I mentioned earlier. I just haven't been getting home early enough to actually work on the two features :-)

This way I get the big refactoring out of the way, and hopefully see that its stable across many users and each of their different ways of using password maker. I've been using this for a couple of days now on my phone without a problem.

Thanks for taking the time to sorta beta test this.

tasermonkey commented 10 years ago

Released! I will make new issues for your suggestions. Also any issues that come from this I will deal with in new issues.