search

passwordmaker / chrome-passwordmaker

A browser extension based on passwordmaker.org. Create unique passwords for every webpage using a cryptographic hash algorithm.
https://passwordmaker.org
GNU Lesser General Public License v3.0
92 stars 52 forks source link

Grouping of profiles #167

Open gwillegers opened 6 years ago

gwillegers commented 6 years ago

As a user of the original PasswordMaker Firefox extension, I have a list of over 200 profiles. They are organised in groups. It would be nice to be able to create (sub-)groups to organise the profiles. Sorting the groups and profiles would also be nice to have.

jeremy-harnois commented 6 years ago

I have sorting working in a local development version but need to clean it up before making a pull request for it.

heavensrevenge commented 6 years ago

Right on, by chance are you able to also sort them into sub groups? I also had sorting in my local branch but didn't attack sub groups yet for organisational purposes related to issue #167. It isn't needed yet but I'll eventually like to implement groups after sortibility.

On Fri, Apr 20, 2018, 5:22 PM Jeremy Harnois, notifications@github.com wrote:

I have sorting working in a local development version but need to clean it up before making a pull request for it.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/passwordmaker/chrome-passwordmaker/issues/167#issuecomment-383246247, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAjeHG1uunW0HT6idtJp5Lc9Gs0OAeYks5tqm23gaJpZM4S7Um3 .

jeremy-harnois commented 6 years ago

I didn't address grouping because I didn't feel it was necessary after I added sorting for myself. I'm also coming from Firefox with a lot of profiles, and sorting solved the major usability issues I was having. I'm curious to see if it does the same for @gwillegers. @gwillegers, how were you using groups?

I think other features would be more useful and would, at least for me, solve the same problems I was using grouping to solve. IOW, grouping may have been used to solve usability issues that should probably be addressed with more specific solutions. Two features I'd find useful that would replace how I was using groups would be:

  1. The ability to pin profiles to the top of the popup list (for those frequently used profiles that aren't associated with a website or that are needed in applications that use websites but hide toolbars), and
  2. The ability to archive profiles so they're only visible in options (for those infrequently or no longer used profiles that I keep around just in case)
gwillegers commented 6 years ago

I created groups for things like work, finance, webshops, holidays, hobbies. IMO it makes it easier to find an account. Sorting helps, but sorting and grouping would be ideal. (BTW: the original PasswordMaker only had groups, no sorting.)

heavensrevenge commented 6 years ago

Where's your grouping code? @gwillegers I'd like to review it and maybe add it.

gwillegers commented 6 years ago

A misunderstanding must have slipped into this discussion. Grouping accounts is just part of the functionality of the original Passwordmaker extension for Firefox. You can create accounts, but you can also create groups, and create accounts in a group (just like files and directories, although I don't know if nested groups are possible). I did not code it myself. I just used it.

heavensrevenge commented 6 years ago

Oh OK @gwillegers I was under thinking you had it coded, I should give it a shot soon.

jeremy-harnois commented 6 years ago

The lack of sorting was my biggest complaint about the old Firefox extension; grouping only helped so much. @gwillegers, when are you manually looking for an account instead of relying on pattern matching to automatically select the account for you?

I was considering a filter-as-you-type feature—both in the popup and options—as a way to more easily find accounts when I have to look for them manually. While that's a different approach than what you're used to, I feel like that would be a better (easier, quicker) feature than grouping.

gwillegers commented 6 years ago

Looking for an account is mostly when I want to change something. Some passwords have to be changed periodically, or the webiste's URL changes (so I need to change the patterns). Most of the time the pattern matching is sufficient to select the right account.

heavensrevenge commented 6 years ago

Hey @jeremy-harnois if you like to test out my filter feature, try pulling from my master branch and see if it works for you 😄

heavensrevenge commented 6 years ago

I pushed out version 0.8.8 with the profile filter and alphanumeric sorting features for you both to try out @jeremy-harnois and @gwillegers

gwillegers commented 6 years ago

Works great! Filtering is a nice alternative for grouping. Will these changes automatically find their way to the Firefox port mentioned by @dolohow in issue #163? I am mainly using that (because most of the time I use FF instead of Chrome).

dolohow commented 6 years ago

I submitted new version to Mozilla. Waiting for approval.

heavensrevenge commented 6 years ago

Well I'm glad filtering seems to be working OK for people.

jeremy-harnois commented 6 years ago

Thanks @heavensrevenge ... now I can use a legitimate release :-)

heavensrevenge commented 6 years ago

Right on @jeremy-harnois, I wonder if its a suitable alternative for grouping though, if so, either @gwillegers or me can close this issue.

heavensrevenge commented 6 years ago

So @jeremy-harnois how are you liking it so far?

jeremy-harnois commented 6 years ago

I like it; seems to work well, @heavensrevenge. Filtering also solves an issue I was having with not being able to see the selected profile's details when selecting a profile after about the 50th one unless I scrolled back to the top.

I don't feel there's a need for grouping, but that's @gwillegers request, so I'll let him comment on whether or not he thinks it's still needed after he's had some more time to work with filtering and sorting.

heavensrevenge commented 6 years ago

That's good to hear, I was curious on feedback after people have had some time to play with it. Filtering was SO much more simple and clean to implement vs grouping and even drag & drop sorting. So I'd be happy if I didn't need to add drag & drop or groups to not add ~ 200 lines of code lol

heavensrevenge commented 7 months ago

@jeremy-harnois I believe I fixed and optimized regex profile matching which I based on your ~5yo branch but didn't need to add another option field or profile entry via commit c0a55af. By the way @gwillegers I've released an updated Passwordmaker Pro on the Mozilla add-ons site so this is exact feature equivalent in Firefox now too!

jeremy-harnois commented 7 months ago

c0a55af also fixes #186 (and its duplicate #185), @INeedCaffeine 👍