Can't customize character set

[koreth]

I use a custom character set with the other PasswordMaker extensions (Firefox and the earlier Chrome one), but it looks like this extension only allows me to choose from a list of canned character sets.

[yshavit]

I'll take a stab at this.

[bitboxer]

Sorry, I simply forgot to add that to the settings gui. The backend system can handle manual entered characters.

[yshavit]

I just added it to the settings gui -- but git is confusing the heck out of me! I'm going to just upload my changed files to my little git corner... Here we go: http://github.com/downloads/yshavit/chrome-passwordmaker/custom_charsets_gui.zip

[bitboxer]

http://book.git-scm.com/ <= Good book about git.

[yshavit]

Thanks! Someday I'll read up about git in full. For now, it's 1:20am so I'm going to bed. :) Good night!

Btw I'm not at all married to the UI, feel free to change it up. But this should at least get a decent start on the backend of the frontend, as it were.

(I updated my comment above with the link to the patched docs.)

[bitboxer]

I would do it in a different way:

• Add a "Custom character set"-Field to the select box
• If the "Custom character set" is selected, show a field under the select box with the positility to enter a list of characters
• If the list has < 2 characters, it has to show a warning when pressing save

[bitboxer]

That way it's easier for the user. He don't has to switch to another menu and than switch back to actually select the characters.

[yshavit]

That's fine with me -- the only thing is that if a user needs multiple custom character sets, that could clutter the UI; and also, would the custom charsets be defined on a per-profile basis?

I don't actually use custom charsets, so I'm not sure what the common use cases are. And since I don't actually use them, I have no vested interest in how it gets implemented. :-)

[bitboxer]

We can add the user entered character sets from all other profiles to the select box.

[litui]

This is the #1 thing preventing me from switching to Chrome from FF right now. I can manually migrate my profiles, but I do need to be able to manually input character set strings as I modified my default in PM in firefox (so all my data has a modified set).

I'm with bitboxer. A "customize" option in the dropdown that pops up a text input (pre-populated with the default set). It'd be handy if each of the custom sets on profiles were added to the dropdown, but not necessary as profiles can be cloned, and copy/paste works just fine.

[bitboxer]

I will work on this starting tomorrow.

[bitboxer]

Closed by 30a849f97dc7177d12ecdfaa99800b20823ab223 : Add custom charsets

[koreth]

Thanks! This works brilliantly now.

[litui]

Hum... doesn't seem to be working quite so brilliantly for me... when trying to match my default profile's character string to my default in PM in firefox, I'm not getting the same passwords... even weirder, on the second attempt it generated a completely different password...

[litui]

I'll add that I'm using SHA-256.

[bitboxer]

Can you send me the character set you us?

[litui]

Sure: ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789_-+^&%#$@!*(){}[]

[bitboxer]

Sorry, I can't reproduce the problem :( . On my chrome it always generates the same password. And the password is like the firefox one.

Could you recheck it? Maybe on another chrome installation on another computer? Has anybody else the same problem?

[litui]

Apologies. It does look to be working. I incorrectly left my username out of my default. Now it's all good. Case closed.

Also thanks for getting this feature working =).

[bitboxer]

Perfect!