Fix issue #88 - Githubissues

passy / Android-DirectoryChooser

A directory chooser library for Android.

Apache License 2.0

515 stars 144 forks source link

Fix issue #88 #116

Closed ParkerK closed 6 years ago

ParkerK commented 6 years ago

Added JitPack, as com.gu.Option hasn't been updated in years, and they never pushed to JCenter or any other repo, so I used JitPack

Contributor checklist

[x] I have read the Contribution Guidelines
[ ] My commit messages follow the Conventional Commit Message Format
[x] My contribution is fully baked and ready to be merged as is

Description

passy commented 6 years ago

The -SNAPSHOT version seems odd. Is that intended?

CI doesn't seem very happy about it:


* What went wrong:
A problem occurred configuring project ':sample'.
> Could not resolve all dependencies for configuration ':sample:_debugApkCopy'.
   > Could not find com.github.guardian:Option:-SNAPSHOT.
     Required by:
         project :sample > project :library

ParkerK commented 6 years ago

Huh, CI doesn't seem to check JitPack, it seems to be trying to get the package from Maven. Also, all of a sudden com.gu.option:1.3 is working again for me now.

passy commented 6 years ago

CI doesn't really have any special setup that would cause this from resolving deps differently. I tried it locally and I'm seeing the same error. :/

passy commented 6 years ago

Thanks for kicking this off, @ParkerK!

I changed this a bit and commited it as 143bd4323ce21709528e23cde6cdb314af37f9db. I needed to set up the jitpack repository for the entire project as the sample would otherwise fail to build. I've also set it to a specific commit instead of the snapshot to keep the build reproducible.

ParkerK commented 6 years ago

Ahhh, I think I had removed the sample as I'm using the library for my app. Sorry for overlooking that, and thanks for finding the issue!