passy / angular-masonry

An AngularJS directive for Masonry.
https://passy.github.io/angular-masonry
MIT License
1.12k stars 216 forks source link

update AngularJS to 1.5 #159

Closed jodytate closed 8 years ago

jodytate commented 8 years ago

Works well with AngularJS 1.5. Currently using it in two projects with the latest of angular-masonry (v0.15.0) and latest AngularJS.

I’ve updated the Bower file and package.json. Along with that, the version of PhantomJS is updated. Without bumping to 2.1 you’ll see the following error from Karma when running the unit tests:

TypeError: 'undefined' is not an object (evaluating 'Function.prototype.bind.apply’)

That error was discussed/fixed in issue 56 of karma-phantomjs-launcher.

passy commented 8 years ago

Thanks, @jodytate! Could you please check the contribution section of the readme about the commit guidelines?

jodytate commented 8 years ago

very sorry i missed something so obvious.