passy / build-time-tracker-plugin

Gradle plugin to continuously track and report your build times
https://plugins.gradle.org/plugin/net.rdrei.android.buildtimetracker
Apache License 2.0
1.21k stars 67 forks source link

TrueTimeProvider has moved as of gradle 3.3 #75

Closed gverwers closed 7 years ago

gverwers commented 7 years ago

All of the classes using TrueTimeProvider are failing with class not found because TrueTimeProvider has moved from org.gradle.internal to org.gradle.internal.time. As changing this TrueTimeProvider to it's new package will break all users of prior version of gradle. I would suggest creating your own implementation of TrueTimeProvider or use the code from TrueTimeProvider.

Caused by: java.lang.NoClassDefFoundError: org/gradle/internal/TrueTimeProvider at net.rdrei.android.buildtimetracker.reporters.CSVReporter.run(CSVReporter.groovy:18) at net.rdrei.android.buildtimetracker.reporters.CSVReporter$run.call(Unknown Source) at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:48) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:113) at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:125) at net.rdrei.android.buildtimetracker.TimingRecorder$_buildFinished_closure1.doCall(TimingRecorder.groovy:53) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

passsy commented 7 years ago

breakes every build

...
:app:clean
:clean

BUILD SUCCESSFUL

Total time: 0.893 secs

FAILURE: Build failed with an exception.

* What went wrong:
Failed to notify build listener.
gverwers commented 7 years ago

I don’t think is worth it to use the gradle internal class anymore.

From: Pascal Welsch [mailto:notifications@github.com] Sent: Wednesday, January 04, 2017 12:17 PM To: passy/build-time-tracker-plugin build-time-tracker-plugin@noreply.github.com Cc: VERWERS, GARY gv8839@att.com; Author author@noreply.github.com Subject: Re: [passy/build-time-tracker-plugin] TrueTimeProvider has moved as of gradle 3.3 (#75)

breakes every build

...

:app:clean

:clean

BUILD SUCCESSFUL

Total time: 0.893 secs

FAILURE: Build failed with an exception.

Failed to notify build listener.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/passy/build-time-tracker-plugin/issues/75#issuecomment-270444196, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXw5HdXAHPrL_Iav_RuwsnIwsJRP39quks5rO-IbgaJpZM4LauzY.

passy commented 7 years ago

Hey, I appreciate the report. Given the size of the class, I agree that shipping a custom implementation is probably the best option.

I won't have time to look into this for the next weeks or so. If anyone else wants to work on this, please go ahead. :)