passy / ctlmngr

A manager for custom timelines
MIT License
21 stars 2 forks source link

Fix Analytics code inclusion after reduce step #37

Closed passy closed 10 years ago

passy commented 10 years ago

/ping @Munter :)

Since the GA inclusion (https://github.com/passy/ctlmngr/blob/f0362e356a53f77fec48f5aa8fa04edbcf21ad76/app/index.html#L60-68) is already asynchronous, I'd like to keep that piece of code out of the bundled file, especially as it's at the very end of it. Is there any way of annotating that snippet in the code to exclude it from the bundling process?

Otherwise some GA features aren't available because they rely on a apparently pretty basic crawler that checks for the existence of the snippet in the HTML.

Munter commented 10 years ago

If I remember correctly you should be able to set a nobundle attribute on that script tag to exclude it from bundling

passy commented 10 years ago

You are my hero, @Munter!

Munter commented 10 years ago

I'm just glad my memory still works :smiley_cat: