search

passy / golden_retriever

Apache License 2.0
0 stars 0 forks source link

Add clippy check to CI #6

Open passy opened 8 years ago

passy commented 8 years ago

https://github.com/Manishearth/rust-clippy

Requires nightly to compile at the moment, but would be nice to get the checks.

passy commented 8 years ago

Maybe without CI.

daithiocrualaoich commented 8 years ago

Added clippy to the Dockerfile but stumped a little on a clean way to run it in CI. It has to be run only in the build with nightly Rust and not in the builds with stable or beta. My only current idea for this is to write a build script for the CI job that checks the compiler version. But I don't like that because the .travis.yml is quite tidy at the moment and this approach will sick all over it.

Note that the nightly is allowed to fail so we won't necessarily get notified of clippy breaks.

Thoughts?