search

passy / google-cdn

Replaces references to resources on the Google CDN
BSD 3-Clause "New" or "Revised" License
70 stars 29 forks source link

Windows fix #10

Closed trask closed 10 years ago

trask commented 10 years ago

Currently get this error when running on Windows:

Error: spawn ENOENT
    at errnoException (child_process.js:980:11)
    at Process.ChildProcess._handle.onexit (child_process.js:771:34)

Using which seems to be the standard way to fix this type of issue based on https://github.com/gruntjs/grunt/pull/156

passy commented 10 years ago

Thanks for the PR, @trask. Could you rebase this?

trask commented 10 years ago

Rebased. Also I just noticed I had broken the Travis CI build, I had to mock out the which dependency for tests. Green now. Thanks.

passy commented 10 years ago

Could you change the commit to something like fix(cdnify): execution on windows using full path?

trask commented 10 years ago

Done. I also updated the jshint rules in a separate commit in case you want to take that also.

passy commented 10 years ago

Thank you!