Closed dbrakenhoff closed 1 year ago
This is now dealt with in #88.
DictConnector
now gets a default name and doesn't necessarily need to be passed by user. It's not used for anything anyway, so a default value makes creating a DictConnector easier.PasConnector
now actually uses the name
argument as the name of the directory in which the data will be stored. The path
argument is now the location where to create/read that directory. This is a breaking change, see instructions below.PastaStore
now expects the Connector
object as the first argument. The name
argument is now optional, if it is not provided, it will take the name from the Connector object. WARNING! This change will introduce two breaking changes:
pst.PastaStore(name, connector)
to pst.PastaStore(connector, name=name)
with the name becoming optional.pst.PasConnector
the name argument is now used to specify the directory name in which the database will be stored. The path argument defines the location of that directory. This is also a breaking change and will require users to modify their PasConnector
from pst.PasConnector("unused_name", path="./pastas_db")
to pst.PasConnector("pastas_db", path=".")
. This is more in line with the other Connectors.
The PastaStore object now takes a name, which is not something that's really used, so we could default to the connector name and optionally let users pass their own.
The Connectors now take a name and some take a path/connection string. This is not implemented consistently, and also doesn´t make sense for all connectors.
I'm not sure how to make these changes without breaking some old code (for PasConnector), but I think would be good to implement sooner rather than later.