search

pastasfuture / com.hauntedpsx.render-pipelines.psx

A scriptable render pipeline for emulating Playstation-1-style graphics on contemporary hardware.
https://twitter.com/HauntedPs1/
MIT License
383 stars 26 forks source link

Grass is unaffected by realtime lights #11

Closed thebeardphantom closed 2 years ago

thebeardphantom commented 2 years ago

In a scene with Ambient Lighting set to black, grass will render as black and is unaffected by dynamic lights (Directional/Point/Spot).

thebeardphantom commented 2 years ago

I think I found the solution. Neither shader features _BRDF_MODE_LAMBERT or _BRDF_MODE_WRAPPED_LIGHTING are enabled for PSXWavingGrass.shader. This means that all dynamic lighting is essentially bypassed in DynamicLighting::EvaluateDynamicLighting()

thebeardphantom commented 2 years ago

PR: https://github.com/pastasfuture/com.hauntedpsx.render-pipelines.psx/pull/20

pastasfuture commented 2 years ago

It landed in 1.6.0. thanks for the report + fix🖤