search

pastasfuture / com.hauntedpsx.render-pipelines.psx

A scriptable render pipeline for emulating Playstation-1-style graphics on contemporary hardware.
https://twitter.com/HauntedPs1/
MIT License
383 stars 26 forks source link

Lightmap baking errors when using vertex colors and per-pixel lighting #12

Closed PixelDough closed 2 years ago

PixelDough commented 2 years ago

When attempting to bake my lightmaps in my game, a recent issue has shown up where it fails to bake the indirect lighting on materials that have vertex colors and per-pixel lighting enabled, resulting in extremely dark shadows on those materials.

The errors that show up in the console are two: Shader error in 'PSX/PSXLit': 'ApplyVertexColorPerPixelColorVertexColorModeColor': no matching 3 parameter function at /Users/PixelDough/Documents/Unity Projects/ProjectRemade/Packages/HPSXRP/Runtime/Material/PSXLit/PSXLitMetaPass.hlsl(115) (on d3d11) and Shader error in 'PSX/PSXLit': undeclared identifier 'vertexColorBlendMode' at /Users/PixelDough/Documents/Unity Projects/Project/Packages/HPSXRP/Runtime/Material/PSXLit/PSXLitMetaPass.hlsl(115) (on d3d11)

I have pics to show the comparison between before and after this bug started happening. Before: image After: image

pastasfuture commented 2 years ago

Fixed. It landed in 1.6.0. thanks for reportingšŸ–¤