search

pastelsky / bundlephobia

🏋️ Find out the cost of adding a new frontend dependency to your project
https://bundlephobia.com
MIT License
8.99k stars 222 forks source link

ES module package @reactioncommerce/api-plugin-carts fails to show exports analysis #340

Open aldeed opened 4 years ago

aldeed commented 4 years ago

Bug

This package does not show exports analysis, but the package.json has type: "module" and sideEffects: false.

Note that this is a Node-only package so it doesn't have a module field in package.json. Maybe that is why? Nevertheless it is exporting an ES module, and Node doesn't support the module field so there is no reason to add it.

pastelsky commented 3 years ago

You're right. We don't recognize type: "module" today, even though we should. I'd be adding support for this soon.